Retrieve local ijk's of an LGR, given its name #828
Merged
+573
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
2 times, most recently
from
1a44eec to
482e329
Compare
blattms
requested changes
Jan 30, 2025
|
@blattms At some point, some methods related to refinement can be moved into CpGridUtilities, in case the header is kept |
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
from
23d1b90 to
57114b2
Compare
|
jenkins build this please |
1 similar comment
|
jenkins build this please |
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
2 times, most recently
from
1db6f0a to
bd231ba
Compare
|
jenkins build this please |
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
2 times, most recently
from
6fea239 to
24d41ea
Compare
|
jenkins build this please |
|
@blattms if checks are green, then it's ready for review. In the test file, I'm using the essentially the same deck_string only modifying the ACTNUM part. Is there a way to shorten the file using some methods to change the ACTNUM input in each case? |
blattms
requested changes
Feb 5, 2025
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
from
b15176f to
b3bbe3d
Compare
|
All comments have been addressed ready for a final check |
|
jenkins build this please |
|
I think jenkins will fail, running it anyway to prevent a breaking merge |
|
jenkins build this please |
aritorto
force-pushed
the
elemIdxToLocalIJK
branch
from
43d28a8 to
6ce856e
Compare
Co-authored-by: Markus Blatt <[email protected]>
|
jenkins build this please |
|
Thanks, @blattms. Now, it should not fail |
blattms
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate output file generation, it is beneficial to retrieve the local IJK coordinates from each refined level grid based on its name.
Currently, inactive cells in LGRs are not supported in "opm-common." Nevertheless, an lgrIJK() test for a grid containing inactive cells within the LGR block has been added (and commented out). This case test passes if initLgr() is not invoked in opm-common/opm/input/eclipse/EclipseState/EclipseState.cpp.